<html>
<head><meta charset="utf-8"><title>making-more-plans · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html">making-more-plans</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="126747222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747222">(May 18 2018 at 12:47)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> if you want to chat, I'm around now btw</p>



<a name="126747242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747242">(May 18 2018 at 12:47)</a>:</h4>
<p>okay I'll be ready in a minute</p>



<a name="126747569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747569">(May 18 2018 at 12:54)</a>:</h4>
<p>okay, few more delays but here now.</p>



<a name="126747579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747579">(May 18 2018 at 12:55)</a>:</h4>
<p>we doing this via Zulip, or via some video chat system?</p>



<a name="126747581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747581">(May 18 2018 at 12:55)</a>:</h4>
<p>either way</p>



<a name="126747583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747583">(May 18 2018 at 12:55)</a>:</h4>
<p>might as well chat over zulip I guess</p>



<a name="126747587"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747587" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747587">(May 18 2018 at 12:55)</a>:</h4>
<p>won't be able to include digressions about James Bond over zulip</p>



<a name="126747589"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747589" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747589">(May 18 2018 at 12:55)</a>:</h4>
<p>oh, you <em>can</em></p>



<a name="126747593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747593">(May 18 2018 at 12:55)</a>:</h4>
<p>/me found a new podcast</p>



<a name="126747594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747594">(May 18 2018 at 12:55)</a>:</h4>
<p>:)</p>



<a name="126747595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747595">(May 18 2018 at 12:56)</a>:</h4>
<p>Anyway</p>



<a name="126747642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747642">(May 18 2018 at 12:56)</a>:</h4>
<p>well, so, what I wanted to say is that I was talking to aturon about the Rust 2018 Edition plans overall</p>



<a name="126747645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747645">(May 18 2018 at 12:56)</a>:</h4>
<p>and when I step back for second</p>



<a name="126747651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747651">(May 18 2018 at 12:56)</a>:</h4>
<p>if we consider location-invariant NLL</p>



<a name="126747657"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747657" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747657">(May 18 2018 at 12:57)</a>:</h4>
<p>it is essentially "feature complete", from a certain perspective :)</p>



<a name="126747661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747661">(May 18 2018 at 12:57)</a>:</h4>
<p>heh</p>



<a name="126747667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747667">(May 18 2018 at 12:57)</a>:</h4>
<p>it still needs polish: perf isn't where we'd like it to be, and diagnostics are uncertain</p>



<a name="126747668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747668">(May 18 2018 at 12:57)</a>:</h4>
<p>plus there are some lingering soundness bugs</p>



<a name="126747670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747670">(May 18 2018 at 12:57)</a>:</h4>
<p>Thats with an r+ on the changes to MIR codegen for match?</p>



<a name="126747671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747671">(May 18 2018 at 12:57)</a>:</h4>
<p>yes, assuming that</p>



<a name="126747675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747675">(May 18 2018 at 12:57)</a>:</h4>
<p>diagnostics are the big remaining thing I bet, okay</p>



<a name="126747677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747677">(May 18 2018 at 12:57)</a>:</h4>
<p>which reminds me that I was thinking more about that RFC, and wanted to double check what you were thinking, but that's a topic for another day :)</p>



<a name="126747680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747680">(May 18 2018 at 12:57)</a>:</h4>
<p>but interesting to decide whehter that would trump further perforamcne investgation</p>



<a name="126747681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747681">(May 18 2018 at 12:57)</a>:</h4>
<p>right, so, from a risk management perspective</p>



<a name="126747723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747723">(May 18 2018 at 12:58)</a>:</h4>
<blockquote>
<p>but interesting to decide whehter that would trump further perforamcne investgation</p>
</blockquote>
<p>I did some profiling this morning, but let's revisit it in a sec</p>



<a name="126747732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747732">(May 18 2018 at 12:58)</a>:</h4>
<p>anyway, from a risk mgmt perspetive, Rust 2018 could ship with NLL if we solved diagnostics + perf</p>



<a name="126747735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747735">(May 18 2018 at 12:58)</a>:</h4>
<p>er, with "location-insensitive NLL"</p>



<a name="126747736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747736">(May 18 2018 at 12:58)</a>:</h4>
<p>heh</p>



<a name="126747737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747737">(May 18 2018 at 12:58)</a>:</h4>
<p>needs a snappier name</p>



<a name="126747745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747745">(May 18 2018 at 12:59)</a>:</h4>
<p>and then we could follow up with an improved precision analysis at some point :)</p>



<a name="126747749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747749">(May 18 2018 at 12:59)</a>:</h4>
<p>this is  basically the same conclusion you and I reached</p>



<a name="126747750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747750">(May 18 2018 at 12:59)</a>:</h4>
<p>but I am re-reaching it :)</p>



<a name="126747752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747752">(May 18 2018 at 12:59)</a>:</h4>
<p>might be good to have a succinct summary of which cases it regressed</p>



<a name="126747754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747754">(May 18 2018 at 12:59)</a>:</h4>
<p>or</p>



<a name="126747755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747755">(May 18 2018 at 12:59)</a>:</h4>
<p>hm</p>



<a name="126747756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747756">(May 18 2018 at 12:59)</a>:</h4>
<p>do you mean, where does location sensitive matter?</p>



<a name="126747757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747757">(May 18 2018 at 12:59)</a>:</h4>
<p>I was going to say "for the release notes"</p>



<a name="126747759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747759">(May 18 2018 at 12:59)</a>:</h4>
<p>yeah</p>



<a name="126747760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747760">(May 18 2018 at 12:59)</a>:</h4>
<p>but actually</p>



<a name="126747761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747761">(May 18 2018 at 12:59)</a>:</h4>
<p>who cares</p>



<a name="126747762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747762">(May 18 2018 at 12:59)</a>:</h4>
<p>both of those :)</p>



<a name="126747763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747763">(May 18 2018 at 12:59)</a>:</h4>
<p>why draw attention to our short comings!</p>



<a name="126747764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747764">(May 18 2018 at 12:59)</a>:</h4>
<p>the answer is roughly "the <code>get_default</code> example"</p>



<a name="126747814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747814">(May 18 2018 at 13:00)</a>:</h4>
<p>specifically, cases where you take a borrow and return it</p>



<a name="126747819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747819">(May 18 2018 at 13:00)</a>:</h4>
<p>but only conditionally</p>



<a name="126747822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747822">(May 18 2018 at 13:00)</a>:</h4>
<p>and along other paths, the borrow ends</p>



<a name="126747828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747828">(May 18 2018 at 13:00)</a>:</h4>
<p>right, you removed that test outright</p>



<a name="126747833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747833">(May 18 2018 at 13:00)</a>:</h4>
<p>yeah</p>



<a name="126747834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747834">(May 18 2018 at 13:00)</a>:</h4>
<p>there are other examples I think</p>



<a name="126747836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747836">(May 18 2018 at 13:00)</a>:</h4>
<p>it doesn't <em>have</em> to leave the fn</p>



<a name="126747839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747839">(May 18 2018 at 13:00)</a>:</h4>
<p>but I think in practice that's where this arises the most</p>



<a name="126747841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747841">(May 18 2018 at 13:01)</a>:</h4>
<p>probably vec-push-ref too</p>



<a name="126747851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747851">(May 18 2018 at 13:01)</a>:</h4>
<p>vec-push-ref is this one:</p>



<a name="126747861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747861">(May 18 2018 at 13:01)</a>:</h4>
<p>hmm did we not have a NLL unit test for vec-push-ref in the rust repo</p>



<a name="126747865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747865">(May 18 2018 at 13:01)</a>:</h4>
<div class="codehilite"><pre><span></span>fn foo() {
  let mut v = vec![];
  let p = 22;
  let x = &amp;p;
  if true {
    v.push(x);
  } else {
    //  in here, `p` is not borrowed
  }
  use(v);
}
</pre></div>



<a name="126747917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747917">(May 18 2018 at 13:02)</a>:</h4>
<blockquote>
<p>hmm did we not have a NLL unit test for vec-push-ref in the rust repo</p>
</blockquote>
<p>I was just wondering the same</p>



<a name="126747918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747918">(May 18 2018 at 13:02)</a>:</h4>
<p>oh hmm</p>



<a name="126747920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747920">(May 18 2018 at 13:02)</a>:</h4>
<p>should double check</p>



<a name="126747923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747923">(May 18 2018 at 13:02)</a>:</h4>
<p>or maybe it still works for some reason</p>



<a name="126747925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747925">(May 18 2018 at 13:02)</a>:</h4>
<p>(I don't think we  could have, becasue your PR did not touch any such test)</p>



<a name="126747929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747929">(May 18 2018 at 13:02)</a>:</h4>
<p>I will have to check</p>



<a name="126747930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747930">(May 18 2018 at 13:02)</a>:</h4>
<p>oh that's a solid alteratnive theory</p>



<a name="126747933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747933">(May 18 2018 at 13:02)</a>:</h4>
<p>:)</p>



<a name="126747936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747936">(May 18 2018 at 13:02)</a>:</h4>
<p>anyway I definitely agree that — for our own purposes —</p>



<a name="126747940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747940">(May 18 2018 at 13:02)</a>:</h4>
<p>a good write-up of which patterns we support</p>



<a name="126747943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747943">(May 18 2018 at 13:02)</a>:</h4>
<p>and which we expect to support in the future</p>



<a name="126747944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747944">(May 18 2018 at 13:03)</a>:</h4>
<p>is a good idea</p>



<a name="126747955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747955">(May 18 2018 at 13:03)</a>:</h4>
<p>but not maybe <em>top</em> priority</p>



<a name="126747966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747966">(May 18 2018 at 13:03)</a>:</h4>
<p>anyway, so the question then comes to how to divide up the effort between "polish location insensitive" vs "continue pushing on the newer analysis"</p>



<a name="126747967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747967">(May 18 2018 at 13:03)</a>:</h4>
<p>yeah. Improving the expected user experience</p>



<a name="126747973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747973">(May 18 2018 at 13:03)</a>:</h4>
<p>takes priority over documenting the far-future expectations</p>



<a name="126747981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126747981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126747981">(May 18 2018 at 13:04)</a>:</h4>
<p>I of course want to ensure we do the latter ... but <span class="user-mention" data-user-id="116010">@Aaron Turon</span>  pointed out that, really, would it be so bad if we didn't? I am forced to admit that .. it doesn't matter that much</p>



<a name="126748027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748027">(May 18 2018 at 13:04)</a>:</h4>
<p>Well, if we have volunteers excited about working on the latter</p>



<a name="126748029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748029">(May 18 2018 at 13:04)</a>:</h4>
<p>then let them?</p>



<a name="126748031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748031">(May 18 2018 at 13:04)</a>:</h4>
<p>yeah so roughly that is what I felt like:</p>



<a name="126748033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748033">(May 18 2018 at 13:04)</a>:</h4>
<p>let's you + I (at least) focus on polish</p>



<a name="126748034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748034">(May 18 2018 at 13:04)</a>:</h4>
<p>hopefully we can pull in people to focus on the top priority items, even if they are new people</p>



<a name="126748035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748035">(May 18 2018 at 13:04)</a>:</h4>
<p>and try to spin up tasks</p>



<a name="126748037"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748037" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748037">(May 18 2018 at 13:04)</a>:</h4>
<p>yeah I'm down with that</p>



<a name="126748044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748044">(May 18 2018 at 13:05)</a>:</h4>
<p>and others can choose to do whichever strikes their fancy</p>



<a name="126748049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748049">(May 18 2018 at 13:05)</a>:</h4>
<p>I suispect e.g. <span class="user-mention" data-user-id="116107">@David Wood</span> might be up for tackling some polish-like tasks :)</p>



<a name="126748051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748051">(May 18 2018 at 13:05)</a>:</h4>
<p>/me waves to <span class="user-mention" data-user-id="116107">@David Wood</span></p>



<a name="126748089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748089">(May 18 2018 at 13:06)</a>:</h4>
<p>I would like to try to see how much further I can go with rustc integration before next tuesday mtg</p>



<a name="126748096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748096">(May 18 2018 at 13:06)</a>:</h4>
<p>I certainly could do that.</p>



<a name="126748102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748102">(May 18 2018 at 13:06)</a>:</h4>
<p>yeah I still think rustc integration is key</p>



<a name="126748106"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748106" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748106">(May 18 2018 at 13:06)</a>:</h4>
<p>otherwise I feel like Polonius can't make progress</p>



<a name="126748116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748116">(May 18 2018 at 13:07)</a>:</h4>
<p>I do have some high-level Q's for you on that topic</p>



<a name="126748117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748117">(May 18 2018 at 13:07)</a>:</h4>
<p>but lets tie off this discussion first</p>



<a name="126748128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748128">(May 18 2018 at 13:07)</a>:</h4>
<p>ok so, we could turn to a bit more detailed look at what polish means</p>



<a name="126748181"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748181" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748181">(May 18 2018 at 13:08)</a>:</h4>
<p>maybe need to actually do that review of the ui/*.nll.stderr files?</p>



<a name="126748188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748188">(May 18 2018 at 13:08)</a>:</h4>
<p>yeah, I saw two things:</p>



<a name="126748195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748195">(May 18 2018 at 13:08)</a>:</h4>
<p>categorize into "soundness bug", "ux bug", "all is well" ?</p>



<a name="126748201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748201">(May 18 2018 at 13:08)</a>:</h4>
<p>1. look at a profile (I'm doing that)<br>
2. review the stderr files</p>



<a name="126748207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748207">(May 18 2018 at 13:09)</a>:</h4>
<p>oh right, polish include perf issues</p>



<a name="126748224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748224">(May 18 2018 at 13:09)</a>:</h4>
<p>okay lets talk about the profile first then</p>



<a name="126748288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748288">(May 18 2018 at 13:10)</a>:</h4>
<blockquote>
<p>okay lets talk about the profile first tehn</p>
</blockquote>
<p>ok so here is what I see</p>



<a name="126748302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748302">(May 18 2018 at 13:10)</a>:</h4>
<div class="codehilite"><pre><span></span>lunch-box. perf focus -F 99 &#39;{rustc_mir}&#39; --tree-callees --min-percent 10 --relative | c++filt
Matcher    : {rustc_mir}
Matches    : 2268
Not Matches: 2802
Percentage : 100
Time       : 22.91s at 99 Hz

Tree
| matched `{rustc_mir}` (100% total, 1% self)
: | rustc_mir::borrow_check::nll::compute_regions (33% total, 0% self)
: : | rustc_mir::borrow_check::nll::type_check::type_check_internal (29% total, 0% self)
: : : | rustc_mir::borrow_check::nll::type_check::type_check::{{closure}} (10% total, 0% self)
: : : : | rustc_mir::borrow_check::nll::type_check::liveness::generate (10% total, 1% self)
: | rustc::infer::InferCtxtBuilder::enter (29% total, 0% self)
: : | rustc::ty::context::tls::with_related_context (29% total, 0% self)
: : : | rustc_mir::borrow_check::do_mir_borrowck (29% total, 0% self)
: : : : | &lt;rustc_mir::dataflow::at_location::FlowAtLocation&lt;BD&gt; as rustc_mir::dataflow::at_location::FlowsAtLocation&gt;::reconstruct_statement_effect (19% total, 0% self)
: | rustc_mir::dataflow::do_dataflow (25% total, 0% self)
: : | _ZN9rustc_mir8dataflow5impls7borrows7Borrows35kill_loans_out_of_scope_at_location17h0e83141d89a6718dE.llvm.6243250854293542925 (12% total, 1% self)
: : : | rustc_mir::borrow_check::nll::region_infer::RegionInferenceContext::region_contains_point (11% total, 2% self)
: : | &lt;rustc_mir::dataflow::impls::borrows::Borrows&lt;&#39;a, &#39;gcx, &#39;tcx&gt; as rustc_mir::dataflow::BitDenotation&gt;::statement_effect (10% total, 0% self)
: : : | _ZN9rustc_mir8dataflow5impls7borrows7Borrows35kill_loans_out_of_scope_at_location17h0e83141d89a6718dE.llvm.6243250854293542925 (10% total, 0% self)
</pre></div>



<a name="126748308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748308">(May 18 2018 at 13:10)</a>:</h4>
<p>let me summarize what you are looking at</p>



<a name="126748309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748309">(May 18 2018 at 13:10)</a>:</h4>
<p>first off, that's clap :)</p>



<a name="126748318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748318">(May 18 2018 at 13:10)</a>:</h4>
<p>those %ages are the %age of total time <em>just for borrowck</em></p>



<a name="126748335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748335">(May 18 2018 at 13:10)</a>:</h4>
<p>first observation:</p>



<a name="126748345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748345">(May 18 2018 at 13:11)</a>:</h4>
<p>region propagation is not on there</p>



<a name="126748348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748348">(May 18 2018 at 13:11)</a>:</h4>
<p>you would see it under <code>compute_regions</code></p>



<a name="126748352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748352">(May 18 2018 at 13:11)</a>:</h4>
<p>but making things location invariant basically removed it from the profile</p>



<a name="126748354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748354">(May 18 2018 at 13:11)</a>:</h4>
<p>therefore, <em>just</em> doing SEME alone wouldn't help much</p>



<a name="126748356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748356">(May 18 2018 at 13:11)</a>:</h4>
<p>wait</p>



<a name="126748357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748357">(May 18 2018 at 13:11)</a>:</h4>
<p>now i'm confused</p>



<a name="126748361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748361">(May 18 2018 at 13:11)</a>:</h4>
<p>or okay</p>



<a name="126748364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748364">(May 18 2018 at 13:11)</a>:</h4>
<p>I would see it <em>under</em> compute_regions</p>



<a name="126748369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748369">(May 18 2018 at 13:11)</a>:</h4>
<p>never mind then</p>



<a name="126748425"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748425" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748425">(May 18 2018 at 13:12)</a>:</h4>
<p>okay so <code>type_check_internal</code> is where all the time in <code>compute_regions</code> is going, right?</p>



<a name="126748432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748432">(May 18 2018 at 13:12)</a>:</h4>
<p>here is a more concise variant:</p>
<div class="codehilite"><pre><span></span>lunch-box. perf focus -F 99 &#39;{do_mir_borrowck}&#39; --tree-callees --min-percent 10 --tree-max-depth 2 --relative | c++filt
Matcher    : {do_mir_borrowck}
Matches    : 2086
Not Matches: 2984
Percentage : 100
Time       : 21.07s at 99 Hz

Tree
| matched `{do_mir_borrowck}` (100% total, 0% self)
: | rustc_mir::borrow_check::nll::compute_regions (36% total, 0% self)
: : | rustc_mir::borrow_check::nll::type_check::type_check_internal (31% total, 0% self) [...]
: | rustc_mir::dataflow::do_dataflow (27% total, 0% self)
: : | _ZN9rustc_mir8dataflow5impls7borrows7Borrows35kill_loans_out_of_scope_at_location17h0e83141d89a6718dE.llvm.6243250854293542925 (13% total, 1% self) [...]
: : | &lt;rustc_mir::dataflow::impls::borrows::Borrows&lt;&#39;a, &#39;gcx, &#39;tcx&gt; as rustc_mir::dataflow::BitDenotation&gt;::statement_effect (11% total, 0% self) [...]
: | &lt;rustc_mir::dataflow::at_location::FlowAtLocation&lt;BD&gt; as rustc_mir::dataflow::at_location::FlowsAtLocation&gt;::reconstruct_statement_effect (21% total, 0% self)
: : | &lt;rustc_mir::dataflow::impls::borrows::Borrows&lt;&#39;a, &#39;gcx, &#39;tcx&gt; as rustc_mir::dataflow::BitDenotation&gt;::statement_effect (10% total, 0% self) [...]
: : | _ZN9rustc_mir8dataflow5impls7borrows7Borrows35kill_loans_out_of_scope_at_location17h0e83141d89a6718dE.llvm.6243250854293542925 (10% total, 1% self) [...]
</pre></div>



<a name="126748435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748435">(May 18 2018 at 13:12)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> right</p>



<a name="126748441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748441">(May 18 2018 at 13:12)</a>:</h4>
<p>and, within there</p>



<a name="126748449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748449">(May 18 2018 at 13:13)</a>:</h4>
<p>well some of it is some closure :)I have to see what that is</p>



<a name="126748452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748452">(May 18 2018 at 13:13)</a>:</h4>
<p>and the rest is the liveness computation</p>



<a name="126748453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748453">(May 18 2018 at 13:13)</a>:</h4>
<p>I haven't drilled down  deeper there</p>



<a name="126748455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748455">(May 18 2018 at 13:13)</a>:</h4>
<p>that said, most of the work on liveness is</p>



<a name="126748458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748458">(May 18 2018 at 13:13)</a>:</h4>
<p>well, I don't know, but it's probably figuring out the dropck types</p>



<a name="126748467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748467">(May 18 2018 at 13:13)</a>:</h4>
<p>that's what it was before</p>



<a name="126748473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748473">(May 18 2018 at 13:13)</a>:</h4>
<p>I have to see if there is a smarter way to do that (I suspect .. maybe)</p>



<a name="126748474"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748474" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748474">(May 18 2018 at 13:13)</a>:</h4>
<p>but you're saying that's hurting us more under NLL than it does under AST-borrowck ?</p>



<a name="126748516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748516">(May 18 2018 at 13:14)</a>:</h4>
<p>yeah, I'm not 100% sure why</p>



<a name="126748519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748519">(May 18 2018 at 13:14)</a>:</h4>
<p>hmm.</p>



<a name="126748523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748523">(May 18 2018 at 13:14)</a>:</h4>
<p>any idea how much more?</p>



<a name="126748524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748524">(May 18 2018 at 13:14)</a>:</h4>
<p>there were reasons that were fixed</p>



<a name="126748525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748525">(May 18 2018 at 13:14)</a>:</h4>
<p>but I don't know what the new reasons are</p>



<a name="126748528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748528">(May 18 2018 at 13:14)</a>:</h4>
<p>mm I don't know I can try to find out</p>



<a name="126748530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748530">(May 18 2018 at 13:14)</a>:</h4>
<p>that said, it's interesting to look at the rest of the profile too</p>



<a name="126748532"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748532" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748532">(May 18 2018 at 13:14)</a>:</h4>
<p>right</p>



<a name="126748533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748533">(May 18 2018 at 13:14)</a>:</h4>
<p>e.g. 27% is <code>do_dataflow</code></p>



<a name="126748535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748535">(May 18 2018 at 13:15)</a>:</h4>
<p>I jut don't want us wasting time trying to optimize something</p>



<a name="126748536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748536">(May 18 2018 at 13:15)</a>:</h4>
<p>of that a whopping 13% is killing loans :)</p>



<a name="126748544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748544">(May 18 2018 at 13:15)</a>:</h4>
<p>that is already known to also be slow under AST-borrowck</p>



<a name="126748551"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748551" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748551">(May 18 2018 at 13:15)</a>:</h4>
<p>(i mean, it'd be great to make both faster)</p>



<a name="126748552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748552">(May 18 2018 at 13:15)</a>:</h4>
<p>yeah, I will try to compare</p>



<a name="126748560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748560">(May 18 2018 at 13:15)</a>:</h4>
<p>but last time I looked, and I forget the details <em>why</em>, it was harder in NLL that AST</p>



<a name="126748568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748568">(May 18 2018 at 13:15)</a>:</h4>
<p>okay</p>



<a name="126748573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748573">(May 18 2018 at 13:15)</a>:</h4>
<p>so, rest of profile</p>



<a name="126748574"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748574" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748574">(May 18 2018 at 13:15)</a>:</h4>
<p>I will try to get a better answer why that is though :P</p>



<a name="126748577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748577">(May 18 2018 at 13:15)</a>:</h4>
<p>(deleted)</p>



<a name="126748583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748583">(May 18 2018 at 13:16)</a>:</h4>
<p><code>reconstruct_statement_effect</code> is the other big one</p>



<a name="126748664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748664">(May 18 2018 at 13:17)</a>:</h4>
<p>yeah. let me go skim over those two</p>



<a name="126748685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748685">(May 18 2018 at 13:17)</a>:</h4>
<p>I wrote them (or some version of them) so maybe I have some insight into their slowness</p>



<a name="126748701"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748701" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748701">(May 18 2018 at 13:17)</a>:</h4>
<p>it may just be that we are calling it a lot?</p>



<a name="126748703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748703">(May 18 2018 at 13:17)</a>:</h4>
<p>perf can also give pretty detailed look</p>



<a name="126748705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748705">(May 18 2018 at 13:18)</a>:</h4>
<p>e.g., per line</p>



<a name="126748743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748743">(May 18 2018 at 13:18)</a>:</h4>
<p>so that <em>might</em> show something</p>



<a name="126748770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748770">(May 18 2018 at 13:18)</a>:</h4>
<p>we also haven't made any attempt to adjust the order we visit the Basic blocks, right?</p>



<a name="126748788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748788">(May 18 2018 at 13:19)</a>:</h4>
<p>i.e. isn't RPO supposed to actually perform better on the average?</p>



<a name="126748794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748794">(May 18 2018 at 13:19)</a>:</h4>
<p>maybe that is not worth attacking first</p>



<a name="126748809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748809">(May 18 2018 at 13:19)</a>:</h4>
<p>(oh and of course that depends on the analysis direction...)</p>



<a name="126748810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748810">(May 18 2018 at 13:19)</a>:</h4>
<p>we have not, but .. probably not?</p>



<a name="126748822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748822">(May 18 2018 at 13:19)</a>:</h4>
<p>as an aside, it's instructive to look at <span class="user-mention" data-user-id="116609">@Frank McSherry</span>'s datafrog</p>



<a name="126748867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748867">(May 18 2018 at 13:20)</a>:</h4>
<p>we might get wins from using that for these other computations too</p>



<a name="126748873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748873">(May 18 2018 at 13:20)</a>:</h4>
<p>it works rather differently but seems to be pretty fast :)</p>



<a name="126748880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748880">(May 18 2018 at 13:20)</a>:</h4>
<p>anyway I don't quite know what to get out of this yet</p>



<a name="126748881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748881">(May 18 2018 at 13:20)</a>:</h4>
<p>we need to do more of a deep dive probably</p>



<a name="126748883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748883">(May 18 2018 at 13:20)</a>:</h4>
<p>I could imagine splitting up the two problems</p>



<a name="126748886"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748886" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748886">(May 18 2018 at 13:20)</a>:</h4>
<p>or even 3</p>



<a name="126748887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748887">(May 18 2018 at 13:20)</a>:</h4>
<p>that is:</p>



<a name="126748907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748907">(May 18 2018 at 13:21)</a>:</h4>
<ul>
<li><code>liveness::generate</code> (probably me)</li>
<li><code>kill_loans_out_of_scope</code></li>
<li><code>reconstruct_statement_effect</code></li>
</ul>



<a name="126748910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748910">(May 18 2018 at 13:21)</a>:</h4>
<p>those are the 3 hot spots</p>



<a name="126748914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748914">(May 18 2018 at 13:21)</a>:</h4>
<p>I'm not sure in each case whether we want to optimize the <em>function itself</em> or the <em>way we are using it</em></p>



<a name="126748916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748916">(May 18 2018 at 13:21)</a>:</h4>
<p>usually the latter pays more than the former :)</p>



<a name="126748921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126748921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126748921">(May 18 2018 at 13:21)</a>:</h4>
<p>...but it depends :)</p>



<a name="126749154"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749154" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749154">(May 18 2018 at 13:24)</a>:</h4>
<p>(cc <span class="user-mention" data-user-id="116107">@David Wood</span>, are you interested in trying to do some <a href="#narrow/stream/122657-wg-nll/subject/making-more-plans/near/126748887" title="#narrow/stream/122657-wg-nll/subject/making-more-plans/near/126748887">performance optimization</a>?)</p>



<a name="126749171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749171">(May 18 2018 at 13:25)</a>:</h4>
<p>I'm actually a little surprised that statement_effect shows up in profile</p>



<a name="126749177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749177">(May 18 2018 at 13:25)</a>:</h4>
<p>because the intention, if I remember right</p>



<a name="126749196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749196">(May 18 2018 at 13:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> actually, looking a bit more closely...</p>



<a name="126749198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749198">(May 18 2018 at 13:25)</a>:</h4>
<p>is that you should be calling that O(#stmt) times: Once to build the gen-kill sets</p>



<a name="126749202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749202">(May 18 2018 at 13:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I'm happy to try anything.</p>



<a name="126749204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749204">(May 18 2018 at 13:26)</a>:</h4>
<p><code>kill_loans_out_of_scope_at_location</code> is hotter than I thought</p>



<a name="126749248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749248">(May 18 2018 at 13:26)</a>:</h4>
<p>and a second time after Dataflow is solved, to actually do precise analysis within eac basic block</p>



<a name="126749249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749249">(May 18 2018 at 13:26)</a>:</h4>
<p>overall it accounts for 22% of <strong>total execution time</strong> (not just borrowck)</p>



<a name="126749255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749255">(May 18 2018 at 13:26)</a>:</h4>
<p>borrowck is 41%</p>



<a name="126749257"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749257" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749257">(May 18 2018 at 13:26)</a>:</h4>
<p>so that's fully <strong>half</strong></p>



<a name="126749259"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749259" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749259">(May 18 2018 at 13:26)</a>:</h4>
<p>hmm</p>



<a name="126749260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749260">(May 18 2018 at 13:26)</a>:</h4>
<p>kind of ridiculous</p>



<a name="126749278"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749278" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749278">(May 18 2018 at 13:27)</a>:</h4>
<p>ah, it goes over every borrow</p>



<a name="126749279"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749279" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749279">(May 18 2018 at 13:27)</a>:</h4>
<p>we call that function a lot</p>



<a name="126749287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749287">(May 18 2018 at 13:27)</a>:</h4>
<p>yeah I mean I remember I wrote it quick-n-dirty</p>



<a name="126749288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749288">(May 18 2018 at 13:27)</a>:</h4>
<p>well</p>



<a name="126749290"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749290" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749290">(May 18 2018 at 13:27)</a>:</h4>
<p>O(n) times again</p>



<a name="126749299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749299">(May 18 2018 at 13:27)</a>:</h4>
<p>i.e. it should not be part of the iterative dataflow solving</p>



<a name="126749308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749308">(May 18 2018 at 13:28)</a>:</h4>
<p>well</p>



<a name="126749345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749345">(May 18 2018 at 13:28)</a>:</h4>
<p>but it <em>is</em> part of the walk we do later</p>



<a name="126749352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749352">(May 18 2018 at 13:28)</a>:</h4>
<p>i.e., as we walk down the list of statements</p>



<a name="126749356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749356">(May 18 2018 at 13:28)</a>:</h4>
<p>if I'm not mistaken</p>



<a name="126749364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749364">(May 18 2018 at 13:28)</a>:</h4>
<p>that is, it may be the reason that <code>reconstruct_statement_effect</code> is so expensive</p>



<a name="126749366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749366">(May 18 2018 at 13:28)</a>:</h4>
<p>sure</p>



<a name="126749370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749370">(May 18 2018 at 13:28)</a>:</h4>
<p>I guess part of my problem</p>



<a name="126749375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749375">(May 18 2018 at 13:28)</a>:</h4>
<p>is that I don't know how many iterations dataflow is taking to converge</p>



<a name="126749378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749378">(May 18 2018 at 13:28)</a>:</h4>
<p>in the bad cases</p>



<a name="126749387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749387">(May 18 2018 at 13:29)</a>:</h4>
<p>indeed it is called by the various <code>_effect</code> routines</p>



<a name="126749392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749392">(May 18 2018 at 13:29)</a>:</h4>
<p>so my initial thinking of "where is the dataflow solving taking up time"</p>



<a name="126749396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749396">(May 18 2018 at 13:29)</a>:</h4>
<p>may be an incorrect intuition</p>



<a name="126749403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749403">(May 18 2018 at 13:29)</a>:</h4>
<p>I can probably tell you that</p>



<a name="126749410"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749410" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749410">(May 18 2018 at 13:29)</a>:</h4>
<p>that is, I can look where the <code>effect</code> functions are being called from</p>



<a name="126749473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749473">(May 18 2018 at 13:30)</a>:</h4>
<p>well</p>



<a name="126749476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749476">(May 18 2018 at 13:30)</a>:</h4>
<p>is walk_cfg in the profile?</p>



<a name="126749482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749482">(May 18 2018 at 13:30)</a>:</h4>
<p>it appears that they are called about 2/3 directly from <code>do_mir_borrowck</code> (or something inlined into it) and 1/3 from <code>do_dataflow</code></p>



<a name="126749487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749487">(May 18 2018 at 13:30)</a>:</h4>
<p>walk-cfg is not in the profile</p>



<a name="126749497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749497">(May 18 2018 at 13:31)</a>:</h4>
<p>okay</p>



<a name="126749507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749507">(May 18 2018 at 13:31)</a>:</h4>
<p>because <code>fn dataflow </code> is in two parts</p>



<a name="126749513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749513">(May 18 2018 at 13:31)</a>:</h4>
<p><code>build_sets()</code> makes the entry gen and kill  sets</p>



<a name="126749523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749523">(May 18 2018 at 13:31)</a>:</h4>
<p>but it is not iterative</p>



<a name="126749540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749540">(May 18 2018 at 13:31)</a>:</h4>
<p>and then <code>propagate()</code> does the iterative solution to the dataflow eqns.</p>



<a name="126749598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749598">(May 18 2018 at 13:32)</a>:</h4>
<p>so my guess is that you'll see <code>build_sets()</code> in the profile.</p>



<a name="126749610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749610">(May 18 2018 at 13:32)</a>:</h4>
<p>just because that construction is so darn expensive?</p>



<a name="126749612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749612">(May 18 2018 at 13:32)</a>:</h4>
<p>mm 0%</p>



<a name="126749615"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749615" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749615">(May 18 2018 at 13:32)</a>:</h4>
<p>but sometimes inlining makes that misleading</p>



<a name="126749616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749616">(May 18 2018 at 13:32)</a>:</h4>
<p>hmm</p>



<a name="126749633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749633">(May 18 2018 at 13:33)</a>:</h4>
<p>or else my tool is broken somehow ;)</p>



<a name="126749641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749641">(May 18 2018 at 13:33)</a>:</h4>
<p>but it seems to be yielding coherent results</p>



<a name="126749661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749661">(May 18 2018 at 13:33)</a>:</h4>
<p>is your full stack trace showing the call chain to<code> _effect</code> visible somewhere?</p>



<a name="126749662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749662">(May 18 2018 at 13:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116107">@David Wood</span> well this seems pretty important; I'm not 100% sure what to do yet, it's going to bear some digging around.</p>



<a name="126749667"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749667" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749667">(May 18 2018 at 13:33)</a>:</h4>
<blockquote>
<p>is your full stack trace showing the call chain to<code> _effect</code> visible somewhere?</p>
</blockquote>
<p>I can paste it</p>



<a name="126749722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749722">(May 18 2018 at 13:34)</a>:</h4>
<div class="codehilite"><pre><span></span>lunch-box. perf focus -F 99 &#39;{statement_effect}&#39; --tree-callers | c++filt
Matcher    : {statement_effect}
Matches    : 696
Not Matches: 4374
Percentage : 13
Time       : 7.03s at 99 Hz

Tree
| matched `{statement_effect}` (13% total, 0% self)
: | rustc_mir::borrow_check::do_mir_borrowck (8% total, 0% self)
: : | rustc::ty::context::tls::with_related_context (8% total, 0% self)
: : : | rustc::infer::InferCtxtBuilder::enter (8% total, 0% self)
: : : : | rustc_mir::borrow_check::mir_borrowck (8% total, 0% self)
: : : : : | [unknown] (8% total, 8% self)
: : : : : | rustc::ty::maps::&lt;impl rustc::ty::maps::config::QueryConfig&lt;&#39;tcx&gt; for rustc::ty::maps::queries::mir_borrowck&lt;&#39;tcx&gt;&gt;::compute (0% total, 0% self)
: : : : : : | [unknown] (0% total, 0% self)
: | rustc_mir::dataflow::do_dataflow (4% total, 0% self)
: : | rustc_mir::borrow_check::do_mir_borrowck (4% total, 0% self)
: : : | rustc::ty::context::tls::with_related_context (4% total, 0% self)
: : : : | [unknown] (4% total, 4% self)
: : : : | rustc::infer::InferCtxtBuilder::enter (0% total, 0% self)
: : : : : | [unknown] (0% total, 0% self)
: | rustc_mir::dataflow::do_dataflow (0% total, 0% self)
: : | rustc_mir::borrow_check::do_mir_borrowck (0% total, 0% self)
: : : | rustc::ty::context::tls::with_related_context (0% total, 0% self)
: : : : | rustc::infer::InferCtxtBuilder::enter (0% total, 0% self)
: : : : : | [unknown] (0% total, 0% self)
</pre></div>



<a name="126749733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749733">(May 18 2018 at 13:34)</a>:</h4>
<p>oh I see, it looks like a direct call from <code>do_dataflow</code> to <code>xxx_effect</code>, right?</p>



<a name="126749736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749736">(May 18 2018 at 13:34)</a>:</h4>
<p>yes</p>



<a name="126749740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749740">(May 18 2018 at 13:34)</a>:</h4>
<p>yeah that sounds like inlining to me</p>



<a name="126749744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749744">(May 18 2018 at 13:34)</a>:</h4>
<p>sometimes I go and add <code>#[inline(never)]</code></p>



<a name="126749748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749748">(May 18 2018 at 13:34)</a>:</h4>
<p>when doing this sort of thing</p>



<a name="126749750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749750">(May 18 2018 at 13:34)</a>:</h4>
<p>to various big fns</p>



<a name="126749753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749753">(May 18 2018 at 13:34)</a>:</h4>
<p>where inlining looks unlikely to be profitable</p>



<a name="126749756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749756">(May 18 2018 at 13:34)</a>:</h4>
<p>LLVM really likes to inline</p>



<a name="126749777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749777">(May 18 2018 at 13:35)</a>:</h4>
<p>anyway, I suspect we should spin off a distinct thread focused on this and carry on independently</p>



<a name="126749782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749782">(May 18 2018 at 13:35)</a>:</h4>
<p>and turn to the diagnostics topic?</p>



<a name="126749786"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749786" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749786">(May 18 2018 at 13:35)</a>:</h4>
<p>okay sure</p>



<a name="126749860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749860">(May 18 2018 at 13:36)</a>:</h4>
<p>ok...</p>



<a name="126749862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749862">(May 18 2018 at 13:36)</a>:</h4>
<p>so as for diagnostics</p>



<a name="126749867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749867">(May 18 2018 at 13:36)</a>:</h4>
<p>I guess the main job is that we need to categorize?</p>



<a name="126749891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749891">(May 18 2018 at 13:37)</a>:</h4>
<p>yeah whoops that's a task I failed to follow up on</p>



<a name="126749903"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749903" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749903">(May 18 2018 at 13:37)</a>:</h4>
<p>how many such files are there anyway</p>



<a name="126749919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749919">(May 18 2018 at 13:37)</a>:</h4>
<p>answer: 169</p>



<a name="126749965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749965">(May 18 2018 at 13:38)</a>:</h4>
<p>I see 171</p>



<a name="126749968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749968">(May 18 2018 at 13:38)</a>:</h4>
<p>ok</p>



<a name="126749970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749970">(May 18 2018 at 13:38)</a>:</h4>
<p>but close enough</p>



<a name="126749971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749971">(May 18 2018 at 13:38)</a>:</h4>
<p>well, yeah</p>



<a name="126749973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749973">(May 18 2018 at 13:38)</a>:</h4>
<p>this is some random branch of mine</p>



<a name="126749984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749984">(May 18 2018 at 13:38)</a>:</h4>
<p>after this meeting I have to go run errands</p>



<a name="126749988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126749988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126749988">(May 18 2018 at 13:38)</a>:</h4>
<p>otherwise I'd offer to immediately make the todo list or this</p>



<a name="126750006"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750006" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750006">(May 18 2018 at 13:39)</a>:</h4>
<p>well it's easy enough to massage those into a todo list</p>



<a name="126750008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750008">(May 18 2018 at 13:39)</a>:</h4>
<p>I can do that</p>



<a name="126750011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750011">(May 18 2018 at 13:39)</a>:</h4>
<p>the thing I'm mostly interested in</p>



<a name="126750014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750014">(May 18 2018 at 13:39)</a>:</h4>
<p>is <em>how</em> we expect to categorize</p>



<a name="126750019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750019">(May 18 2018 at 13:39)</a>:</h4>
<p>i.e., are there a fixed set of buckets?</p>



<a name="126750022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750022">(May 18 2018 at 13:39)</a>:</h4>
<p>I think you had a sample before</p>



<a name="126750121"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750121" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750121">(May 18 2018 at 13:41)</a>:</h4>
<p>"soundness bug", "ux bug", "all is well"</p>



<a name="126750189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750189">(May 18 2018 at 13:42)</a>:</h4>
<p>hmm</p>



<a name="126750190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750190">(May 18 2018 at 13:42)</a>:</h4>
<p>(of course deviation from AST-borrowck does not immediately imply a bug. )</p>



<a name="126750193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750193">(May 18 2018 at 13:42)</a>:</h4>
<p>sounds decent :)</p>



<a name="126750198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750198">(May 18 2018 at 13:42)</a>:</h4>
<p>we may want one more category?</p>



<a name="126750201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750201">(May 18 2018 at 13:42)</a>:</h4>
<p>can you think of more categories?</p>



<a name="126750202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750202">(May 18 2018 at 13:42)</a>:</h4>
<p>or maybe that's a good start</p>



<a name="126750206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750206">(May 18 2018 at 13:42)</a>:</h4>
<p>I can imagine wanting to drill into ux bug a bit more</p>



<a name="126750207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750207">(May 18 2018 at 13:42)</a>:</h4>
<p>or subdivisions of interest?</p>



<a name="126750211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750211">(May 18 2018 at 13:42)</a>:</h4>
<p>okay</p>



<a name="126750212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750212">(May 18 2018 at 13:42)</a>:</h4>
<p>e.g., "MY EYES" vs "meh"</p>



<a name="126750214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750214">(May 18 2018 at 13:42)</a>:</h4>
<p>yes</p>



<a name="126750219"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750219" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750219">(May 18 2018 at 13:42)</a>:</h4>
<p>maybe like "wrong span" vs "totally illegible"</p>



<a name="126750224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750224">(May 18 2018 at 13:42)</a>:</h4>
<p>missing suggestions and tips will be a common thing</p>



<a name="126750236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750236">(May 18 2018 at 13:43)</a>:</h4>
<p>but I'm not sure we want to categorize in this way</p>



<a name="126750243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750243">(May 18 2018 at 13:43)</a>:</h4>
<p>that is, it might be more like <em>how important is that suggestion/span/etc</em></p>



<a name="126750249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750249">(May 18 2018 at 13:43)</a>:</h4>
<p>(that's kind of a judgement call, obviously)</p>



<a name="126750253"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750253" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750253">(May 18 2018 at 13:43)</a>:</h4>
<p>I kind of like just weighing importance, as you put it in "MY EYES" vs "meh"</p>



<a name="126750258"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750258" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750258">(May 18 2018 at 13:43)</a>:</h4>
<p>yeah</p>



<a name="126750260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750260">(May 18 2018 at 13:43)</a>:</h4>
<p>yeah its subjective, but okay</p>



<a name="126750261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750261">(May 18 2018 at 13:43)</a>:</h4>
<p>I think that might be best</p>



<a name="126750264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750264">(May 18 2018 at 13:43)</a>:</h4>
<p>seems like that is ultimately what matters</p>



<a name="126750266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750266">(May 18 2018 at 13:43)</a>:</h4>
<p>I guess subjectivity is troublesome</p>



<a name="126750270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750270">(May 18 2018 at 13:43)</a>:</h4>
<p>well it's just a first scratch</p>



<a name="126750271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750271">(May 18 2018 at 13:43)</a>:</h4>
<p>because that means it may be hard to delegrate?</p>



<a name="126750274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750274">(May 18 2018 at 13:43)</a>:</h4>
<p>I mean we get the most important</p>



<a name="126750276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750276">(May 18 2018 at 13:43)</a>:</h4>
<p>then we go to the rest</p>



<a name="126750277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750277">(May 18 2018 at 13:43)</a>:</h4>
<p>and re-triage</p>



<a name="126750320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750320">(May 18 2018 at 13:44)</a>:</h4>
<p>rinse, repeat until we run out of time <span class="emoji emoji-1f389" title="party popper">:party_popper:</span></p>



<a name="126750322"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750322" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750322">(May 18 2018 at 13:44)</a>:</h4>
<p>well</p>



<a name="126750331"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750331" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750331">(May 18 2018 at 13:44)</a>:</h4>
<p>how do we catch cases erroneously categorized as "meh"</p>



<a name="126750339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750339">(May 18 2018 at 13:44)</a>:</h4>
<p>in the second pass?</p>



<a name="126750340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750340">(May 18 2018 at 13:44)</a>:</h4>
<p>without reviewing  all UX bugs all the time?</p>



<a name="126750345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750345">(May 18 2018 at 13:44)</a>:</h4>
<p>(deleted)</p>



<a name="126750350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750350">(May 18 2018 at 13:44)</a>:</h4>
<p>I guess i'm imagining we don't :)</p>



<a name="126750351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750351">(May 18 2018 at 13:44)</a>:</h4>
<p>hmm  I guess if there are a finite number of passes</p>



<a name="126750352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750352">(May 18 2018 at 13:44)</a>:</h4>
<p>until we've dealt with the rest</p>



<a name="126750355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750355">(May 18 2018 at 13:45)</a>:</h4>
<p>then its not really an issue, okay</p>



<a name="126750364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750364">(May 18 2018 at 13:45)</a>:</h4>
<p>or maybe somebody reports it separately and we decide to promote</p>



<a name="126750371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750371">(May 18 2018 at 13:45)</a>:</h4>
<p>ultimately i'm not that worried, I feel like the main thing is we have to pick some stuff to focus on <em>somehow</em></p>



<a name="126750379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750379">(May 18 2018 at 13:45)</a>:</h4>
<p>(deleted)</p>



<a name="126750431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750431">(May 18 2018 at 13:46)</a>:</h4>
<p>oh there is one more .... maybe work item ...</p>



<a name="126750447"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750447" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750447">(May 18 2018 at 13:46)</a>:</h4>
<p>we probably should port more (all?) compile-fail tests to <code>ui/</code></p>



<a name="126750452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750452">(May 18 2018 at 13:46)</a>:</h4>
<p>in order that they get subject to this .nll.stderr thing</p>



<a name="126750458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750458">(May 18 2018 at 13:46)</a>:</h4>
<p>or is that a waste of effort ?</p>



<a name="126750478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750478">(May 18 2018 at 13:47)</a>:</h4>
<p>hmm</p>



<a name="126750479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750479">(May 18 2018 at 13:47)</a>:</h4>
<p>not sure</p>



<a name="126750481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750481">(May 18 2018 at 13:47)</a>:</h4>
<p>it would probably (vastly?) increase the workload in terms of number of .nll.stderr files to review</p>



<a name="126750482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750482">(May 18 2018 at 13:47)</a>:</h4>
<p>but maybe we put it off :)</p>



<a name="126750487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750487">(May 18 2018 at 13:47)</a>:</h4>
<p>idea:</p>



<a name="126750488"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750488" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750488">(May 18 2018 at 13:47)</a>:</h4>
<p>schedule 30 min or 1 hour</p>



<a name="126750491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750491">(May 18 2018 at 13:47)</a>:</h4>
<p>maybe monday</p>



<a name="126750495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750495">(May 18 2018 at 13:47)</a>:</h4>
<p>to do this together</p>



<a name="126750502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750502">(May 18 2018 at 13:47)</a>:</h4>
<p>i.e., to get started</p>



<a name="126750505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750505">(May 18 2018 at 13:47)</a>:</h4>
<p>see if we can come up with criteria</p>



<a name="126750508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750508">(May 18 2018 at 13:47)</a>:</h4>
<p>I suspect after we do a few</p>



<a name="126750509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750509">(May 18 2018 at 13:47)</a>:</h4>
<p>you first since there's only ~170</p>



<a name="126750510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750510">(May 18 2018 at 13:47)</a>:</h4>
<p>it'll be clearer</p>



<a name="126750552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750552">(May 18 2018 at 13:48)</a>:</h4>
<p>oh</p>



<a name="126750556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750556">(May 18 2018 at 13:48)</a>:</h4>
<p>I see now</p>



<a name="126750560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750560">(May 18 2018 at 13:48)</a>:</h4>
<p>there aren't <em>that</em> many, it's true</p>



<a name="126750565"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750565" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750565">(May 18 2018 at 13:48)</a>:</h4>
<p>you're not intending that we finish in that time frame</p>



<a name="126750568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750568">(May 18 2018 at 13:48)</a>:</h4>
<p>necessarily</p>



<a name="126750571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750571">(May 18 2018 at 13:48)</a>:</h4>
<p>right</p>



<a name="126750573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750573">(May 18 2018 at 13:48)</a>:</h4>
<p>just that we better understand the task at hand</p>



<a name="126750576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750576">(May 18 2018 at 13:48)</a>:</h4>
<p>yeah I figured after we do like 5-10</p>



<a name="126750577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750577">(May 18 2018 at 13:48)</a>:</h4>
<p>okay. I'm good with that plan, I think.</p>



<a name="126750585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750585">(May 18 2018 at 13:48)</a>:</h4>
<p>we can do it live over zulip even and others can kibbitz if they like :)</p>



<a name="126750598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750598">(May 18 2018 at 13:49)</a>:</h4>
<p>beautful</p>



<a name="126750604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750604">(May 18 2018 at 13:49)</a>:</h4>
<p>make a separate topic for each .nll.stderr file. ;)</p>



<a name="126750608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750608">(May 18 2018 at 13:49)</a>:</h4>
<p>okay</p>



<a name="126750611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750611">(May 18 2018 at 13:49)</a>:</h4>
<p>so that's performance and diagnostics</p>



<a name="126750660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750660">(May 18 2018 at 13:50)</a>:</h4>
<p>(let me go schedule a meeting for monday now, let you decide whether it works for you)</p>



<a name="126750673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750673">(May 18 2018 at 13:50)</a>:</h4>
<p>I think (my) monday morning is basically free</p>



<a name="126750674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750674">(May 18 2018 at 13:50)</a>:</h4>
<p>oh</p>



<a name="126750678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750678">(May 18 2018 at 13:50)</a>:</h4>
<p>monday is a holiday here. Logan's daycare is closed</p>



<a name="126750687"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750687" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750687">(May 18 2018 at 13:50)</a>:</h4>
<p>The evening might work</p>



<a name="126750699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750699">(May 18 2018 at 13:51)</a>:</h4>
<p>would you be around at 1pm your time?</p>



<a name="126750711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750711">(May 18 2018 at 13:51)</a>:</h4>
<p>(then again, maybe this is not a good subject matter for a 10pm meeting)</p>



<a name="126750713"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750713" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750713">(May 18 2018 at 13:51)</a>:</h4>
<p>or wait</p>



<a name="126750715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750715">(May 18 2018 at 13:51)</a>:</h4>
<p>time zone math!</p>



<a name="126750761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750761">(May 18 2018 at 13:52)</a>:</h4>
<p>I'll just put something down and let you react to it</p>



<a name="126750780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126750780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126750780">(May 18 2018 at 13:53)</a>:</h4>
<p>okay</p>



<a name="126836515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/making-more-plans/near/126836515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/making-more-plans.html#126836515">(May 20 2018 at 16:15)</a>:</h4>
<p>One thing in the context of error messages: Ideally NLL will reduce the total number of compiler errors that people get. You could say that a (temporary) regression in the quality of the errors they do get will be amortized by less overall errors experienced.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>